Update to .NET 9 #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bash merged 13 commits into main from dotnet-9

Jan 13, 2025

Member

bash commented Jan 13, 2025

Partially addresses #796

bash added 7 commits

January 13, 2025 12:01


          Update to .NET 9

5c9b8a9


          Call .ConfigureAwait and pass cancellation token

f0e9e50


          Add new parse extensions

483142e


          Update internal source generator to latest analyzer version

c88da57


          Use ForAttributeWithMetadataName instead of filtering manually

9ff025d


          Support default values in source gen

8f30fe3


          Give the IReadOnlyDictionary overload priority

00a50d6

bash commented

View reviewed changes

Funcky.Async/Extensions/AsyncEnumerableExtensions/PowerSet.cs Show resolved Hide resolved

bash commented

View reviewed changes

Funcky.SourceGenerator/OrNoneFromTryPatternGenerator.cs Show resolved Hide resolved

bash commented

View reviewed changes

Funcky.SourceGenerator/Funcky.SourceGenerator.csproj Show resolved Hide resolved

bash commented

View reviewed changes

Funcky/Extensions/ParseExtensions/ParseExtensions.AssemblyNameInfo.cs Show resolved Hide resolved

bash commented

View reviewed changes

Funcky/Extensions/ParseExtensions/ParseExtensions.TypeName.cs Show resolved Hide resolved

bash added 2 commits

January 13, 2025 12:10


          Don't test against EOL target frameworks

57abd91

xunit.runner.visualstudio only supports >= net6.0 and .NET Framework


          Install .NET 8 on CI

25e920e

Member Author

bash commented Jan 13, 2025

I had to cherry-pick 57abd91 from #797 because .NET Core 3.1 tests fail on Ubuntu: https://github.com/polyadic/funcky/actions/runs/12745799898/job/35520528447?pr=798

bash added 3 commits

January 13, 2025 12:36


          Remove source link package

dddab1c

Starting with .NET 8, source link is included in the SDK


          Only audit direct deps

f3047f9


          Suppress addition of notnull constraint in .NET Core 3.1

97c1ed9

bash marked this pull request as ready for review

January 13, 2025 12:03

bash requested a review from FreeApophis

January 13, 2025 12:03

bash enabled auto-merge

January 13, 2025 12:03

FreeApophis reviewed

View reviewed changes

Directory.Build.props Show resolved Hide resolved

Funcky/Extensions/ParseExtensions/ParseExtensions.AssemblyNameInfo.cs Show resolved Hide resolved

Funcky/Extensions/ParseExtensions/ParseExtensions.TypeName.cs Show resolved Hide resolved

Funcky/Extensions/DictionaryExtensions.cs Outdated Show resolved Hide resolved


          Use less arbitrary number

ba75ecb

FreeApophis approved these changes

View reviewed changes

bash merged commit 76bcf69 into main

8 checks passed

bash deleted the dotnet-9 branch

January 13, 2025 18:34

FreeApophis mentioned this pull request

Release Funcky update with .NET 9 and create a new Version 3.5.0 #796

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet